Allow keywords to be used as annotation names. #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
the
core
fruffy
reviewed
Sep 6, 2024
| @@ -561,6 +561,60 @@ annotationBody | |||
| } | |||
| ; | |||
|
|
|||
| annotationName | |||
| : ABSTRACT { $$ = new IR::ID(@1, "abstract"_cs); } | |||
There was a problem hiding this comment.
Is there a way to just defer to KEYWORD in yacc? Otherwise we have to manually keep track of this every time we add a new keyword.
There was a problem hiding this comment.
The issue is the lexer needs to decide what is a keyword without using any contextual info. We could perhaps change all the keywords to contain the string as a sematic value (so all of these actions would become { $$ = new IR::ID(@1, $1); }, but we'd still need to actually add all the rules in the grammar.
There was a problem hiding this comment.
I was thinking of a way to generate these rules automatically based on the KEYWORD list, but it looks like there is no way.
ChrisDodd
force-pushed
the
cdodd-annotfix
branch
3 times, most recently
from
c321f99
to
9da1dd7
Compare
fruffy
approved these changes
Sep 19, 2024
ChrisDodd
force-pushed
the
cdodd-annotfix
branch
from
9da1dd7
to
d0ca1a5
Compare
Signed-off-by: Chris Dodd <cdodd@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The P4 spec says that keywords can be used freely in annotation bodies with no special meaning. That sort-of implies they can be used as an annotation name as well, which we previously weren't allowing.